Audio playback #201
Open
Audio playback #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcAsironman
requested changes
Nov 12, 2024
There was a problem hiding this comment.
@AmarHadzic All checks have failed. Please review your work and resubmit it. In addition, I noticed that when I click on the audio URL, it doesn't redirect to the browser.
rcAsironman
requested changes
Nov 14, 2024
There was a problem hiding this comment.
@AmarHadzic could you please write test cases for the functionality you worked on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
What was changed
The audio playback was fixed so that users can listen to recorded audio. Now it is an inline url that users can click on and open link, which leads the user to a chrome window and an audio player.
Why was it changed
Previously, users were not able to listen to recorded audio. Also, on the inline editor, nothing would show up after a user recorded audio. These issues led to poor user experience. Now users are able to playback their recorded audio, leading to an improved user experience.
How was it changed
Refactored and changed
insertAudioToEditorfunction to handle and set theaudioUrias an<a> </a>tag. This allows users to highlight and open the audio as a link. The audio linkconst audioLink = `${currentContent}<a href="${audioUri}">${audioUri}</a><br>`;captures previous content such as images, videos, or other audio and updates the inline editor.Updated interface
